Moved all DOM helpers in src/node.js

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform

http://guardian.github.io/scribe/

Apache License 2.0

3.51k stars 245 forks source link

Moved all DOM helpers in src/node.js #404

Closed regiskuckaertz closed 9 years ago

regiskuckaertz commented 9 years ago

In reference to https://github.com/guardian/scribe/issues/397

This is a first step, I spotted a lot of redundant code that could be replaced with calls to DOM helpers. I'll leave that to another PR not to overwhelm you guys.

rrees commented 9 years ago

Looks like a sensible consolidation :+1:

I wouldn't want to see files of more than 200 or 300 lines though.

regiskuckaertz commented 9 years ago

I agree 100%, at some point this module can be split in sub-modules, similar to api.js.

rrees commented 9 years ago

Can you merge in the upstream master? Then I'll try and release next week.