JS error on each keystroke coming from scribe-plugin-smart-lists.js

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform

http://guardian.github.io/scribe/

Apache License 2.0

3.51k stars 245 forks source link

JS error on each keystroke coming from scribe-plugin-smart-lists.js #408

Closed trevordixon closed 9 years ago

trevordixon commented 9 years ago

Uncaught TypeError: Cannot read property 'isBlockElement' of undefinedfindBlockContainer @ scribe-plugin-smart-lists.js:26

scribe

regiskuckaertz commented 9 years ago

@rrees My previous PR introduced a backwards-incompatible change by removing scribe.element. I thought about going through all the plugins I knew of, but I find adding it back as an alias of scribe.node and mark it as obsolete would be a better fit. If that's fine with you, I'll submit a PR asap.

rrees commented 9 years ago

@regiskuckaertz Okay, sounds good but it's probably worth changing the plugins as well

rrees commented 9 years ago

@trevordixon this should be fixed now, can you confirm?

trevordixon commented 9 years ago

Yep, no more error.