Fixes issue 381 - Githubissues

regiskuckaertz commented 9 years ago

This fixes the issue https://github.com/guardian/scribe/issues/381 where two characters are left off the selection after the indent command is executed.

This does not fix:

the behaviour where multiple Ps are automatically converted into a single H2 (step 2 of the process outlined in the issue which is something to do with scribe-plugin-heading-command)
FF only: the behaviour where the selection is lost and therefore the whole operation fails when scribe.el is focused (something to do with scribe-plugin-toolbar)

Not strictly related but I thought could come in handy: the changes in selection serve to spare the need of creating many Selection instances by calling the update method instead. In fact, I was wondering if Selection wouldn't be better as a singleton.

rrees commented 9 years ago

Could you add some unit tests to demonstrate the behaviour/fix?

regiskuckaertz commented 9 years ago

Sure, I'll work this out today

rrees commented 9 years ago

The tests are failing, if you have the chance to look then I think I'd be happy to merge.

regiskuckaertz commented 9 years ago

This may be that I need to bring this PR up to date will the latest changes. I'll look into it when I get back next week. Thanks!

regiskuckaertz commented 9 years ago

oh, that is my own test failing. I'll see what's wrong this evening.

regiskuckaertz commented 9 years ago

Yeah!

rrees commented 9 years ago

Awesome, I'll look into releasing it soon

rrees commented 8 years ago

@regiskuckaertz second favour of the day, could you rebase with master so I can release this?

regiskuckaertz commented 8 years ago

Sure!

guardian / scribe

Fixes issue 381 #413