Remove chrome artifacts

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform

http://guardian.github.io/scribe/

Apache License 2.0

3.51k stars 245 forks source link

Remove chrome artifacts #415

Closed regiskuckaertz closed 9 years ago

regiskuckaertz commented 9 years ago

There was some redundancy across several modules regarding an unwanted behaviour in Chrome. I moved the removeChromeArtifacts over to the node helpers and rewrote the affected parts. Additionally, I made sure SPANs were removed only if they had no attributes.

rrees commented 9 years ago

Overall looks sound to me :+1:, would value a second opinion from the team though.

regiskuckaertz commented 9 years ago

There it is, indeed it's nicer. Thanks for the suggestion @rrees

rrees commented 9 years ago

Small (last) thing could the module be called constants rather than vars. Because they are actually invariants.

regiskuckaertz commented 9 years ago

No problemo, I'll take care of this tonight :+1: