search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.51k stars 245 forks source link

Add event to command #428

Closed ghost closed 9 years ago

ghost commented 9 years ago

While navigating an ordered list, execute is called when a backspace or enter key is pressed. A plugin might want to know which key was pressed so it can decide how to handle the request. Event has been added to the command.

ghost commented 9 years ago

Here is the issue associated with this pull request: https://github.com/guardian/scribe/issues/425

rrees commented 9 years ago

This seems reasonable to me, although it might be nice to be more consistent about passing an event to the Command in future.

ghost commented 9 years ago

Would you like me to change it? Or are you willing to merge as is?

rrees commented 9 years ago

@josh-infusionsoft I'll merge as is but if you have time to propose another PR that'll be great.