guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.5k stars 245 forks source link

Formatters that returns Promises #443

Closed triptec closed 6 years ago

triptec commented 8 years ago

This is just how I could work I guess, thoughts?

rrees commented 8 years ago

With the state of the test suite this is something that might take some time to get this merged. This is to allow user-functions to be chained to the formatters right?

theefer commented 8 years ago

Nice idea, but there may be wide ranging implications with making formatters async that will require thorough testing to avoid breaking current code.

triptec commented 8 years ago

Well my use case is that if there is a link pasted in the editor I would like to substitute it with a [link src='' type=internal | external etc] and to be able to determine if it's a internal src I need to make a http get and therefor return a promise.

I guess most plugins won't need to return a promise and that works to, obviously we need to get the tests running, I might be able to help with that, just wanted to know if this is something you could see going in to the codebase.

I also would like to know if there's a better way to handle my use case but I still think it would be nice to have formatters able to handle promises if needed.

This might have a performance impact though and that could be a good reason not to make it work this way, I guess we could add async formatters instead of changing a current api.

ping @rrees , @theefer

rrees commented 8 years ago

Yeah, adding a specific async formatter is definitely going to be easier to get into production