search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.5k stars 245 forks source link

Pull requests welcome? #504

Open rhedin opened 8 years ago

rhedin commented 8 years ago

Hello. I am starting to work with this package. It looks nice. Thanks!

I wonder whether pull requests are welcome. I see some things I would like to change. For example, ctrl-z is hard-coded as the undo character. In some situations, people might want it to be something else, especially non-English-speakers.

But the maintainers of the package might not feel that such changes are worth pulling into the main branch, or they might even feel that such changes make the code worse. Shall I submit pull requests? Or shall I fork it? 

       Regards, Rick
rrees commented 7 years ago

In this case it seems sensible to pull the current behaviour into the default configuration behaviour and then allow it to be over-ridden if you want it.