guardian / ssm-scala

ssh replacement: CLI program that wraps SSM's EC2 Run Command
Apache License 2.0
21 stars 0 forks source link

Make -x (execute) the default behaviour #375

Closed philmcmahon closed 6 months ago

philmcmahon commented 6 months ago

What does this change?

This PR modifies ssm-scala so that you no longer need to pass -x or --execute in order to get it to execute the ssh command.

In 7 years of using SSM, I don't think I have ever wanted to run a command without -x. The only use case has been for scripts which have made use of --raw to build a more complex ssh command. With that in mind, I have modified the --raw setting so that it now disables execution.

This PR introduces a new 'dryrun' command line option as a way of getting the old behaviour back (printing out the ssh command rather than executing).

As this affects the default behaviour of SSM I this will need to be at least a minor version bump and I'll send out some comms as well after releasing.

What is the value of this?

Two characters less typing every time anyone uses SSM. Only 2 characters! So best not to think about this PR too much or it will take another year to pay off!

Any additional notes?

mchv commented 6 months ago

👍 from me