search

guardian / support-frontend

💁‍♀️❤️📰 Frontend for the Supporter platform
https://support.theguardian.com/
26 stars 13 forks source link

Wrong campaign name mapping for failed paper (Home Delivery) checkouts #5296

Open graham228221 opened 1 year ago

graham228221 commented 1 year ago

This should actually be print-failed, not paper-failed:

https://github.com/guardian/support-frontend/blob/ceb09f6d6af15cbf047013ad3c5bd10846c86543/support-workers/src/main/scala/com/gu/emailservices/FailedContributionEmailFields.scala#L18

The name (DataExtensionName) must match the mapping in membership-workflow here: https://github.com/guardian/membership-workflow/blob/main/conf/PROD.public.conf#L49C10-L49C10

andrewHEguardian commented 1 week ago

@graham228221 is this still an issue?

graham228221 commented 1 week ago

@graham228221 is this still an issue?

I think so, it should be print-failed to match membership-workflow here: https://github.com/guardian/membership-workflow/blob/930f01291dacff565e32661d794a8abacf8ce7da/conf/PROD.public.conf#L50C5-L50C17 - this would cause an error in the membership-workflow queue, meaning no email would be sent.

But actually, the campaign that print-failed corresponds to if switched off in Braze: https://dashboard-01.braze.eu/engagement/campaigns/5da4706298cf4b552292cd31/5b75933b36dc781650d85641?locale=en&page=-2 and I just noticed that it shares the same campaign id as digipack-failed. So there's a few problems here, but yes I think this should be updated in support-frontend so that there is at least a corresponding mapping in membership-workflow.