guardian / support-frontend

💁‍♀ī¸â¤ī¸đŸ“° Frontend for the Supporter platform
https://support.theguardian.com/
26 stars 13 forks source link

Comment out SEPA from validPaymenMethods on generic checkout #6276

Closed GHaberis closed 2 months ago

GHaberis commented 2 months ago

What are you doing in this PR?

Currently we show users from the EU "SEPA" as a payment method on the generic checkout. There are 2 issues here, 1) we have not implemented SEPA as a payment method, so selecting the payment method does nothing, and 2) SEPA is currently turned off on the non-generic checkout, so it shouldn't be listed as a valid payment method. The quickest change to resolve the issue we have right now is to comment out SEPA. Next steps would be:

1) Check payment method switch is ON when adding them to validPaymentMethods 2) Check whether we intend to reintroduce SEPA, and if so reimplement on the generic checkout.

github-actions[bot] commented 2 months ago

Deploy build 11043 of support::stripe-patrons-data to CODE

All deployment options - [Deploy build 11043 of `support::stripe-patrons-data` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=support%3A%3Astripe-patrons-data&build=11043&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 11043 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=support%3A%3Astripe-patrons-data&build=11043&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=support%3A%3Astripe-patrons-data&stage=CODE)

From guardian/actions-riff-raff.

github-actions[bot] commented 2 months ago

Size Change: -12 B (0%)

Total Size: 2.25 MB

ℹī¸ View Unchanged | Filename | Size | Change | | :--- | :---: | :---: | | `./public/compiled-assets/javascripts/[countryGroupId]/events/router.js` | 112 kB | 0 B | | `./public/compiled-assets/javascripts/[countryGroupId]/router.js` | 253 kB | -12 B (0%) | | `./public/compiled-assets/javascripts/ausMomentMap.js` | 108 kB | 0 B | | `./public/compiled-assets/javascripts/contributionsRedirectStyles.js` | 20 B | 0 B | | `./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js` | 240 kB | 0 B | | `./public/compiled-assets/javascripts/downForMaintenancePage.js` | 69.3 kB | 0 B | | `./public/compiled-assets/javascripts/error404Page.js` | 69.3 kB | 0 B | | `./public/compiled-assets/javascripts/error500Page.js` | 69.2 kB | 0 B | | `./public/compiled-assets/javascripts/favicons.js` | 617 B | 0 B | | `./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js` | 194 kB | 0 B | | `./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js` | 86.1 kB | 0 B | | `./public/compiled-assets/javascripts/payPalErrorPage.js` | 67.8 kB | 0 B | | `./public/compiled-assets/javascripts/payPalErrorPageStyles.js` | 20 B | 0 B | | `./public/compiled-assets/javascripts/promotionTerms.js` | 72.4 kB | 0 B | | `./public/compiled-assets/javascripts/subscriptionsLandingPage.js` | 71.5 kB | 0 B | | `./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js` | 126 kB | 0 B | | `./public/compiled-assets/javascripts/supporterPlusLandingPage.js` | 306 kB | 0 B | | `./public/compiled-assets/javascripts/unsupportedBrowserStyles.js` | 20 B | 0 B | | `./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js` | 191 kB | 0 B | | `./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js` | 86 kB | 0 B | | `./public/compiled-assets/webpack/136.js` | 2.17 kB | 0 B | | `./public/compiled-assets/webpack/272.js` | 18.1 kB | 0 B | | `./public/compiled-assets/webpack/344.js` | 2.04 kB | 0 B | | `./public/compiled-assets/webpack/430.js` | 81.8 kB | 0 B | | `./public/compiled-assets/webpack/841.js` | 19.8 kB | 0 B |

compressed-size-action

github-actions[bot] commented 2 months ago

Deploy build 20307 of support:support-workers-mono to CODE

All deployment options - [Deploy build 20307 of `support:support-workers-mono` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=support%3Asupport-workers-mono&build=20307&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 20307 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=support%3Asupport-workers-mono&build=20307&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=support%3Asupport-workers-mono&stage=CODE)

From guardian/actions-riff-raff.

prout-bot commented 2 months ago

Seen on PROD (merged by @GHaberis 10 minutes and 30 seconds ago)

Sentry Release: support-client-side, support