search

guardian / teamcity-s3-plugin

Teamcity plugin for uploading artifacts to S3
Apache License 2.0
36 stars 18 forks source link

Retry if we get a reset during upload #3

Closed philwills closed 9 years ago

philwills commented 9 years ago

We've seen this happen a few times and it's always worked when re-run, so try to shortcut that.

philwills commented 9 years ago

Haven't been able to reproduce failure, so would appreciate a second pair of eyes

cc @adamnfish @obrienm

johnduffell commented 9 years ago

fair enough but I like the idea of updating the library version first as retrying things (aka non determinism) always makes me nervous! :+1:

philwills commented 9 years ago

Turns out the Amazon client has retries which are configurable, so going to do that instead.

atward commented 9 years ago

I'm getting this error in production. Is there a workaround?

philwills commented 9 years ago

@atward Yes, #5 and #6 have changed the way we do the upload and that has removed the issue for us, but I forgot to push a release. I've now done that, so hopefully that will help.

atward commented 9 years ago

Thanks. I'll retry with 1.4.0+ and report back.