guardian / toolargetool

A tool to help you debug TransactionTooLargeExceptions on Android 7+
MIT License
1.12k stars 105 forks source link

logBundleBreakDown should show additional logs? #16

Open littlehome-eugene opened 6 years ago

littlehome-eugene commented 6 years ago

I'm calling logBundleBreakDown before calling startActivity

      Intent i = new Intent(activity, ReviewMetaActivity.class);
      i.putExtra(ReviewMetaActivity.ARG_FULL_PATH, fullPath);
      i.putExtra(ReviewMetaActivity.REVIEW_META_ID, review_meta_id);
      i.putExtra(ReviewMetaActivity.REVIEW_THREAD_ID, review_thread_id);
      i.putExtra(ReviewMetaActivity.REVIEW_META_JSONSTRING, review_meta_jsonstring);

      TooLargeTool.logBundleBreakdown("review-meta", i.getExtras());
      activity.startActivity(i);

But log only shows


10-12 19:17:10.376 13893 13893 D TooLargeTool: ReviewMetaActivity.onSaveInstanceState wrote: Bundle@6242526 contains 2 keys and measures 38.9 KB when serialized as a Parcel
10-12 19:17:10.376 13893 13893 D TooLargeTool: * android:viewHierarchyState = 38.7 KB
10-12 19:17:10.376 13893 13893 D TooLargeTool: * com.google.firebase.analytics.screen_service = 0.2 KB

Is there something I'm missing?

maxspencer commented 6 years ago

Hey there, I have one simple idea of what the problem might be:

You're calling logBundleBreakdown with the tag "review-meta". Make sure you are not filtering those log lines out because the instructions in the README assume the default log tag which is "TooLargeTool". You could monitor just logs for this particular intent with:

adb logcat -s "review-meta"

Let me know if that's the problem, if not we can investigate what else it is.