Fix nullability crashes with Kotlin

guardian / toolargetool

A tool to help you debug TransactionTooLargeExceptions on Android 7+

MIT License

1.12k stars 105 forks source link

Fix nullability crashes with Kotlin #23

Closed sebaslogen closed 5 years ago

sebaslogen commented 5 years ago

See bug https://github.com/guardian/toolargetool/issues/22

tkhduracell commented 5 years ago

:+1:

craigomac commented 5 years ago

Can I humbly request that this be merged? I'd like to use it but am also hit by the nullability crash on every attempt.

EDIT: I was able to work around the issue by ensuring no bundle ever passed up to a super.onCreate(Bundle) was ever null. Just a matter of looking at stack traces and inserting Elvis operators all over the place! Still cleaner to have the merge of course 😄 .

maxspencer commented 5 years ago

Brilliant, thank you all 👏