search

guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Add rule manager subproject #103

Closed SHession closed 3 years ago

SHession commented 3 years ago

What does this change?

This PR adds a Rule Manager sub project to the Typerighter repo. It provides us with a starting point for developing the Rule Manager functionality. This PR includes the Play setup but doesn't go as far as to configure the deploy which will be covered in a separate PR.

How to test

From the perspective of the existing checker functionality, this should be a no-op. In terms of the Rule Manager it should be possible to run locally on typerighter.local.dev-gutools.co.uk, this will require nginx to be setup again to account for the change of ports.

How can we measure success?

We are able to proceed with the rule management functionality.

jonathonherbert commented 3 years ago

Be good to have the script start everything – for example, Grid has a runAll command.

Having said that, when I try to define an alias, I get port conflicts – e.g. addCommandAlias("runAll", "all ruleManager/run checker/run") invariably results in a port conflict, as both apps start on the same port:

--- (Running the application, auto-reloading is enabled) ---

--- (Running the application, auto-reloading is enabled) ---

[info] p.c.s.AkkaHttpServer - Listening for HTTP on /0:0:0:0:0:0:0:0:9101

(Server started, use Enter to stop and go back to the console...)

[error] a.i.TcpListener - Bind failed for TCP channel on endpoint [/0.0.0.0:9101]
java.net.BindException: [/0.0.0.0:9101] Address already in use
        at sun.nio.ch.Net.bind0(Native Method)

... possibly because settings in one app are leaking into another. Perhaps I'm doing it wrong?

SHession commented 3 years ago

Be good to have the script start everything – for example, Grid has a runAll command.

Agreed, I tried this locally and had the same problems. I tried for sometime to find a workaround but I haven't be able to get it working. I don't think this is a blocker for this PR but will definitely be useful when we have both subprojects up and running.

SHession commented 3 years ago

👍 Cracking start. I'd probably get rid of the conf/messages and main.js/main.css, as AFAICS we're unlikely to use 'em.

I left those in partly due to the fact git needs a file to version a directory. Happy to remove them if you feel strongly.