Specify major version of RDS only

guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!

Apache License 2.0

276 stars 12 forks source link

Specify major version of RDS only #200

Closed jonathonherbert closed 2 years ago

jonathonherbert commented 2 years ago

What does this change?

Our RDS database is configured to auto update, and has bumped to 13.4. Meanwhile our CDK is hardcoded to 13.3, and AWS sensibly refuses to downgrade when the CFN is deployed.

This PR specifies a major version for the RDS only, letting it drift up minor versions.

How to test

Deploy to CODE. The deployment should succeed.

akash1810 commented 2 years ago

This is failing the build in a confusing way. AFAICT the build steps are successful up to the point of uploading artifacts to Riff-Raff. It also looks like the exit code is 0, which is misleading:

This project currently uses riffRaffNotifyTeamcity to upload to Riff-Raff. Ultimately, this calls the publishArtifacts TeamCity service message.

I'm not sure we strictly need this for this project? Might riffRaffUpload be better? It might surface errors in a more understandable way too 🤞🏽 .

jfsoul commented 2 years ago

I tracked down one of the errors in the server logs for a build of my branch (safe to assume it'll be the same for this one too.) I'm not sure it's particularly helpful unfortunately?

I agree with @akash1810 's suggestion!

jonathonherbert commented 2 years ago

CI issues addressed in #201, thanks for the comments, both.