search

guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

ci: Switch to a more direct upload to Riff-Raff #201

Closed akash1810 closed 2 years ago

akash1810 commented 2 years ago

What does this change?

We've, somewhat randomly (see #200, and #199), started seeing builds fail when uploading artifacts.

The riffRaffNotifyTeamcity task is a proxy to TeamCity's publishArtifacts service message, which allows:

You can publish the build artifacts while the build is still running, immediately after the artifacts are built.

In this change, we switch to the riffRaffUpload task, which uploads artifacts at the end of a build, rather than as they are created.

The hope is this fixes the build, or provides more information to diagnose the underlying issue.

How to test

CI should produce a deployable build.

How can we measure success?

CI is fixed.

A nice side-effect is it's easier to move to GitHub Actions!

akash1810 commented 2 years ago

Thanks for this. I'm quite confused that this has begun to fail. I'll take a look at riffRaffNotifyTeamcity, as I don't yet understand the difference between this and the command that replaces it, but I can see this PR building, so ✅ . Is this happening in other projects?

It's pretty confusing! @jfsoul has done some investigating however it points to an internal error. Regarding other projects being affected, good question, not sure! We'll need to check.