guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Bump dependencies #213

Closed jonathonherbert closed 1 year ago

jonathonherbert commented 1 year ago

What does this change?

Bumps a few dependencies across the board to improve our Snyk scores for this project.

Dev notes

I've consolidated our application setup across the checker and manager apps. Seems fairly straightforward, but perhaps there's a more idiomatic way to do this?

The bump to LanguageTool has been tested with ./script/js/compare-rule-xml.js, to ensure we aren't changing checker behaviour. All of the currently active rules (COMMA_PARENTHESIS_WHITESPACE, DOUBLE_PUNCTUATION, UPPERCASE_SENTENCE_START, WHITESPACE_RULE, SENTENCE_WHITESPACE, PUNCTUATION_PARAGRAPH_END) are not defined in XML, and are fairly self explanatory – I've tested them all in sandbox locally and they appear to work as expected.

How to test

It should compile and run as usual. Snyk should be happy(er).

Tested in CODE. One rule needed to be amended (it had an invalid "skip" property that wasn't being respected anyhow) – I've amended the PROD spreadsheet, so there should be no problem deploying to PROD.

andrew-nowak commented 1 year ago

I get two red checks on the sentence Hi,this is a test sentence. (no space after comma, two spaces between test and sentence) in PROD, but no matches in CODE. Is this a regression?

jonathonherbert commented 1 year ago

Thanks for testing! The CODE and PROD sheets were not in sync, as we've been doing some testing in CODE – I've just copied the PROD LT rules across to CODE, so in CODE you should now see this rule:

Screenshot 2022-12-08 at 14 04 34