search

guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Bump google sheets API packages #235

Closed jonathonherbert closed 1 year ago

jonathonherbert commented 1 year ago

What does this change?

Bumps google sheets API packages, and removed now-unnecessary dependencyOverride, to fix issue with a missing class.

This was causing Uncaught error from thread [application-matcher-pool-dispatcher-24]: Class com.google.common.base.Suppliers$SupplierOfInstance does not implement the requested interface java.util.function.Supplier in #229.

How to test

Run the application locally, or in CODE, and check a document against the checkStream interface. Does the check complete successfully?

Have we considered potential risks?

We currently have no way of defending against problems of this sort. Adding an E2E smoke test that tests a document against a large list of rules may help to prevent errors of this sort reaching production.

jonathonherbert commented 1 year ago

Closed as merged in to #239.