guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

set multiAz to true if DB is PROD, set to false if CODE #236

Closed ParisaTork closed 1 year ago

ParisaTork commented 1 year ago

What does this change?

Sets multiAz to true if DB is PROD - sets it by extension to false if DB is CODE. Relevant AWS config also modified - see Trello for screenshots: https://trello.com/c/N3lnd8HQ Relevant line changed in cdk file - N.B. the snapshot will say multiAz = false - this is the expected behaviour, see Coverdrop as an example:

How to test

Deploy to CODE and check the app/logs are all okay.

How can we measure success?

Have we considered potential risks?

Images

Accessibility

ParisaTork commented 1 year ago

Updating the jest cdk snapshot with yarn but running yarn test -u in the root dir or the cdk dir doesn't work - does anyone know how to update snapshots in TR? Edit: Resolved