Revert "Revert "Move common dependencies to common-lib"" - Githubissues

guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!

Apache License 2.0

276 stars 12 forks source link

Revert "Revert "Move common dependencies to common-lib"" #239

Closed jonathonherbert closed 1 year ago

jonathonherbert commented 1 year ago

Reverts guardian/typerighter#234 and includes https://github.com/guardian/typerighter/pull/235 and a bump to pan-domain-auth to include https://github.com/guardian/pan-domain-authentication/pull/114 – all of which should fix the conflicts with google-api-client that led to the revert.

How to test

[x] Run the application in CODE. It should deploy as expected.
[x] Refresh the rules in the checker. The ingest process should work as expected.
[x] Run a check against a document. It should produce matches as expected.
[x] Import rules via the management system (guidance in #229.) Run a check with these newly imported rules.

Tested all of the above in CODE.