guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Remove refresh logic from the Checker app #294

Closed phillipbarron closed 1 year ago

phillipbarron commented 1 year ago

plus a small update to start script in the rules manager app to automatically terminate the app on ctrl+c

What does this change?

After this change, users will no longer be able to trigger a refresh of the rules from the checker app. Instead, the rule manager UI should be used to pull in changes from the google sheet

How to test

Test that rules are still displayed in the app

Have we considered potential risks?

We should make sure that all rule maintainers know about the new UI available in the rule manager app

Images

Screenshot 2023-03-29 at 12 05 40

Tested locally

phillipbarron commented 1 year ago

Tested on CODE, LGTM!

Worth avoiding merging until we've sent comms to CP and we've verified they're happy.

One suggestion: I wonder whether a convenient link from the Checker UI to the management UI would be useful, as I suspect otherwise it'll be a trip back to the inbox to search for the URL, at least the first few times!

Had the same thought - I will add something 👍

Added the following link...

Screenshot 2023-03-30 at 09 09 13