search

guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Add reason when republishing rule via modal #340

Closed jonathonherbert closed 1 year ago

jonathonherbert commented 1 year ago

What does this change?

Adds a modal asking the user to provide a reason when republishing a rule. The reason appears in the rule history.

It's mandatory at present. Too much?

add-reason

How to test

Go through the workflow shown in the GIF. Does everything work as expected?

jonathonherbert commented 1 year ago

@Fweddi the reasoning for a lack of modal on first publish – the description of the rule should be its justification as it goes out. But there may be context that's useful on first publish, e.g. 'Added in line with new style guidance, 26/06/15'.

Let's talk to Ana and our users a bit more about the 'reason' part of our work, I think this idea stands to be improved.

I think there's a follow up PR to be writtent to make archive and publish make sense to eachother, as we wrote each feature independently.