guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Better user experience when editing rules of different types #352

Closed jonathonherbert closed 1 year ago

jonathonherbert commented 1 year ago

What does this change?

A few tweaks when editing rules of different types:

rule-type

I've also moved the radio buttons nearer the pattern input, as the two fields are very related – one affects the other's presentation.

How to test

Have a play inspecting and editing rules of different types. Do the changes make sense?

rhystmills commented 1 year ago

I think this also include some changes from: https://github.com/guardian/typerighter/pull/354/files

Going to try rebasing on: https://github.com/guardian/typerighter/pull/354/files

Have removed the last three commits and pushed again.