search

guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Layout changes #371

Closed jonathonherbert closed 1 year ago

jonathonherbert commented 1 year ago

What does this change?

A few layout changes. The form content is now scrollable, and the action buttons at the bottom are sticky. The table contents is also scrollable when it exceeds the size of the screen.

The search bar shouldn't scroll with the table, but it's a part of the table component – we've plans to move to another component for rendering our table, so rather than work hard at that, it's probably better to leave it and address when we switch components.

I recommend reviewing with whitespace changes hidden, as there's a bit of shuffling components around and indenting that adds noise to the diff.

layout

How to test

Have a play. Does the new layout work at different viewport sizes? Any edge cases that'd be good to address?

jonathonherbert commented 1 year ago

@samanthagottlieb it's something we've discussed ad-hoc but doesn't have a card yet – I'll write it up shortly 👍