search

guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Edit rule button breaks after selecting a rule #422

Open simonbyford opened 1 year ago

simonbyford commented 1 year ago

To reproduce:

1) Make sure you have the right permissions to edit rules 2) Select any rule using the checkbox on the left 3) Click any edit button on the right. They don't work as expected and show an incorrect tooltip about permissions

Not sure what the expected behaviour should be here. Having both checkboxes and edit buttons is a little confusing?

select-bug

samanthagottlieb commented 1 year ago

We chatted about check boxes vs edit pencils a few weeks ago actually. I believe check boxes were added to enable batch editing, but we did discuss how the presence of both could be confusing. That tooltip about permissions should definitely not appear though, well spotted!