A few UI tweaks/fixes for the rules table

[jonathonherbert]

What does this change?

A few tweaks to the rules table:

• Fixes a crash when users select a rule that's not on page 1 😅
• Adds a summary to indicate how many rules are available for the current search, displayed, and selected (if more than one rule is selected)
• Sorts the rules by ruleType ascending, putting regex rules first, to make the initial rules page look a bit more sensible (we will have ruleType in a column in another PR, which will make this clearer to users) – at the moment we surface LTRuleCore rules first, which results in a very blank first set of rules for PROD datasets (LTRuleCore rules do not have pattern, description etc.)

No selection, no search	With selection	With search

How to test

Have a play in local or CODE. Useful? Comments?

[jonathonherbert]

Thanks for spotting, mistakenly reverted in 4881555, force-pushed to correct.

[jonathonherbert]

@simonbyford yuck, thanks for spotting! Just removed those.

[jonathonherbert]

Great spot, added in a4784b63389e4cd5bff6f7da5554fef8dd01beee – multi-selection is a bit unloved ATM but I think the core state handling will remain the same even as we start to use routes for state when editing individual rules 👍

[simonbyford]

Great spot, added in a4784b6 – multi-selection is a bit unloved ATM but I think the core state handling will remain the same even as we start to use routes for state when editing individual rules 👍

Noice, that did the job!

This is unrelated but I've just noticed something else a bit odd. Try alternating between page 1 and page 5 and note which row gets loaded at the top each time. When I try this locally, the top row changes each time. Could this point to something being wrong with the sorting? Super weirdly, this doesn't happen when alternating between page 1 and page 2.

Happy to pair if any of that doesn't make sense, or if you're seeing something different!