guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Correct asset paths #448

Closed jonathonherbert closed 1 year ago

jonathonherbert commented 1 year ago

What does this change?

445 introduced a routing change that broke the site assets. This PR fixes.

How to test

Run locally, and in CODE. You should see:

Tested:

NB: I had to check in Firefox for the favicon to appear correctly – there appears to be some weird favicon caching in Chrome! Checking the path in the markup manually should verify if it's not appearing straight away in Chrome and you're unsure.

samanthagottlieb commented 1 year ago

The favicon is appearing like this for me locally: Screenshot 2023-10-12 at 15 21 44

However it looks fine on CODE.