guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Only use Prout on endpoints without heavy caching #466

Closed rtyley closed 6 months ago

rtyley commented 7 months ago

Following on from #465, of these two checkpoint endpoints:

...because of the long cache time on Checker, I think it's going to be too confusing to point Prout at it?

image https://prout-bot.herokuapp.com/view/guardian/typerighter

I think if Prout was making a POST request to checker.typerighter.gutools.co.uk, it would presumably get a fresh response from the cache, but it would probably also need to authenticate, for which in Prout there's no mechanism available at the moment.

jonathonherbert commented 6 months ago

Thanks for this, @rtyley! I don't think we should be caching at all – https://github.com/guardian/typerighter/pull/468 explains why, and removes caching entirely, which should mean this is unnecessary ✨