search

guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Don't cache the checker healthcheck endpoint #468

Open jonathonherbert opened 6 months ago

jonathonherbert commented 6 months ago

What does this change?

Don't use caching for the Checker service, to enable the lovely Prout-bot to do its work (#465.)

We use Cloudfront to improve service latency for global users by removing TCP slowstart and reducing TLS handshake latency – we don't care about caching content.

(Initially this PR just removed caching for the healthcheck endpoint (620eb3719971b45860a945ea17ac6794cad54a06), but on reflection I think removing caching entirely is more appropriate.)

How to test

Deploy to CODE or PROD. You should no longer see X-Cache: Hit from cloudfront headers on requests.

jonathonherbert commented 3 months ago

Thanks for testing thoroughly! I'll revisit this PR soon.