search

guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Set rowcount to data array length #470

Closed phillipbarron closed 4 months ago

phillipbarron commented 4 months ago

What does this change?

The total returned by the search endpoint is sometimes greater than the number of rows for some queries in PROD. Not clear why this is but this change will allow editing of rules while we work on the issue with the SQL query

How to test

Check out locally, point at PROD, then try searching for child se - there should be no error. Trying the same in prod results in an unhandled exceptio in the client

How can we measure success?

THe app now working for those search terms

Have we considered potential risks?

This masks the error - we should not move on but fix the underlying issue with the response from the SQL query

prout-bot commented 4 months ago

Seen on Rule Manager (merged by @phillipbarron 11 minutes and 34 seconds ago) Please check your changes!

prout-bot commented 4 months ago

Overdue on Checker (merged by @phillipbarron 15 minutes and 3 seconds ago) What's gone wrong?