guardian / typerighter

Even if you’re the right typer, couldn’t hurt to use Typerighter!
Apache License 2.0
276 stars 12 forks source link

Fix pagination results #471

Closed jonathonherbert closed 3 months ago

jonathonherbert commented 4 months ago

What does this change?

Adds a test and a fix for the odd pagination results patched in #470.

Not quite sure what was causing the original discrepancy, but we were running two queries, one for the data, and one for the count, which made the inconsistency possible.

This PR moves the count columns into the original query, which should remove that inconsistency.

How to test

jonathonherbert commented 3 months ago

@Fweddi great suggestion, done in 67aaf1f and pagination looks good.

prout-bot commented 3 months ago

Seen on Rule Manager (merged by @jonathonherbert 9 minutes and 33 seconds ago) Please check your changes!

prout-bot commented 3 months ago

Overdue on Checker (merged by @jonathonherbert 15 minutes and 3 seconds ago) What's gone wrong?