Added InteractiveFullWidth to Design type obj

jlieb10 commented 3 years ago

What does this change?

We are creating a new DCR template for full-width interactives, essentially combining the 'immersive' style header with the 'interactives' style body. This PR is updating the type so it can be used in DCR and on Composer.

How to test

There are no live articles of this type created yet.

How can we measure success?

Success would look like using this template and keeping TypeScript happy in DCR.

Have we considered potential risks?

This is easily revertible if it causes any unforeseen problems

Images

NA

Accessibility

NA

[ ] Tested with screen reader
[ ] Navigable with keyboard
[ ] Colour contrast passed
[ ] The change doesn't use only colour to convey meaning

JamieB-gu commented 3 years ago

Based on the discussions we've had separately, can we alter this to become Design.FullPageInteractive?

SiAdcock commented 3 years ago

Thanks @jlieb10. Would it be possible to also make this change to the equivalent module in guardian/libs when you have time?

jlieb10 commented 3 years ago

Thanks @jlieb10. Would it be possible to also make this change to the equivalent module in guardian/libs when you have time?

@SiAdcock Thanks Simon - does it matter which order the merge takes place in?

guardian / types