search

guardian / types

A place for types
Apache License 2.0
3 stars 0 forks source link

Adding CLICK_TO_VIEW_EMBED_OVERLAY OphanComponentType #98

Closed frj closed 3 years ago

frj commented 3 years ago

This is to support sending ophan component events for the ClickToView component in DCR.

The click to view component is rendered as a place holder for third party embedded content, which could have ability to track user activity in guardian products.

The overlay forces the users to click to consent to being tracked by the third party before being able to see the content.

This change enables the tracking of that click event.

This reflects the changes made to ophan in this PR:

https://github.com/guardian/ophan/pull/4055

jamie-lynch commented 3 years ago

@frj Is this PR still required? If so, would you mind raising it against guardian/libs now that the Ophan types have been migrated there?

sndrs commented 3 years ago

closing as the associated PR in ophan was closed before merging. if this needs recreating in the future, please open it again in https://github.com/guardian/libs instead