guardianproject / ChatSecureAndroid

This project has ended, but ChatSecure iOS continues. For Android, please use Conversations or Zom instead
https://chatsecure.org/blog/chatsecure-conversations-zom/
Apache License 2.0
1.07k stars 521 forks source link

Service Connection Leaked #445

Open smarek opened 10 years ago

smarek commented 10 years ago

Running 13.1.2 version from F-Droid provided binary.

E/ActivityThread( 4687): android.app.ServiceConnectionLeaked: Activity info.guardianproject.otr.app.im.app.WelcomeActivity has leaked ServiceConnection info.guardianproject.cacheword.CacheWordHandler$2@42d79e38 that was originally bound here
E/ActivityThread( 4687):    at android.app.LoadedApk$ServiceDispatcher.<init>(LoadedApk.java:979)
E/ActivityThread( 4687):    at android.app.LoadedApk.getServiceDispatcher(LoadedApk.java:873)
E/ActivityThread( 4687):    at android.app.ContextImpl.bindServiceCommon(ContextImpl.java:1561)
E/ActivityThread( 4687):    at android.app.ContextImpl.bindService(ContextImpl.java:1544)
E/ActivityThread( 4687):    at android.content.ContextWrapper.bindService(ContextWrapper.java:517)
E/ActivityThread( 4687):    at info.guardianproject.cacheword.CacheWordHandler.connectToService(CacheWordHandler.java:74)
E/ActivityThread( 4687):    at info.guardianproject.otr.app.im.app.WelcomeActivity.connectToCacheWord(WelcomeActivity.java:126)
E/ActivityThread( 4687):    at info.guardianproject.otr.app.im.app.WelcomeActivity.onCreate(WelcomeActivity.java:112)
E/ActivityThread( 4687):    at android.app.Activity.performCreate(Activity.java:5231)
E/ActivityThread( 4687):    at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087)
E/ActivityThread( 4687):    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2159)
E/ActivityThread( 4687):    at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2245)
E/ActivityThread( 4687):    at android.app.ActivityThread.access$800(ActivityThread.java:135)
E/ActivityThread( 4687):    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1196)
E/ActivityThread( 4687):    at android.os.Handler.dispatchMessage(Handler.java:102)
E/ActivityThread( 4687):    at android.os.Looper.loop(Looper.java:136)
E/ActivityThread( 4687):    at android.app.ActivityThread.main(ActivityThread.java:5017)
E/ActivityThread( 4687):    at java.lang.reflect.Method.invokeNative(Native Method)
E/ActivityThread( 4687):    at java.lang.reflect.Method.invoke(Method.java:515)
E/ActivityThread( 4687):    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
E/ActivityThread( 4687):    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
E/ActivityThread( 4687):    at dalvik.system.NativeStart.main(Native Method)
W/ActivityManager( 1641): Unbind failed: could not find connection for android.os.BinderProxy@42f14f48
I/ActivityManager( 1641): START u0 {cmp=info.guardianproject.otr.app.im/.app.NewChatActivity (has extras)} from pid 4687
ikelos commented 10 years ago

I tried this on both the marketplace version, and getting the source and building it myself. It occurs immediately after selecting "set a password", meaning I'm left with an unencrypted database and clear-text passwords stored on the disk. I'm happy to test any patches or help however I can...