guardianproject / haven

Haven is for people who need a way to protect their personal spaces and possessions without compromising their own privacy, through an Android app and on-device sensors
https://guardianproject.github.io/haven/
GNU General Public License v3.0
6.61k stars 726 forks source link

Add heartbeat notifications #270

Closed lukeswitz closed 6 years ago

lukeswitz commented 6 years ago

Feature Description:

Updated

Fills feature request from #54

n8fr8 commented 6 years ago

Excellent, so happy to see this work underway!

n8fr8 commented 6 years ago

In quick testing, it seems to send the heartbeat when the app is open, not just when there is an active monitoring session. Is that the case? I will look through the code more, but just curious what your intention was.

lukeswitz commented 6 years ago

Thanks, that was the intent, to make sure the app is still alive. I didn't hook into any service/activity; when testing, the leaked handler would cease alerts but keep monitoring locally. Your help & thoughts on where/when to monitor are very much appreciated : )

n8fr8 commented 6 years ago

In talking with some of our most committed users, they sometimes have incidents where they forget whether they have activated Haven or not. To them the heartbeat, was a way to confirm that active monitoring was engaged, and if it stopped, to know that someone had turned it off. I would tie this all into the Monitor Service to enable that.

lukeswitz commented 6 years ago

On it.

n8fr8 commented 6 years ago

Cool. Will review soon!