Signal: SSLPeerUnverifiedException using new build settings

guardianproject / haven

Haven is for people who need a way to protect their personal spaces and possessions without compromising their own privacy, through an Android app and on-device sensors

https://guardianproject.github.io/haven/

GNU General Public License v3.0

6.61k stars 726 forks source link

Signal: SSLPeerUnverifiedException using new build settings #273

Closed lukeswitz closed 6 years ago

lukeswitz commented 6 years ago

After merging #269 the Signal functionality broke on both devices & simulators running 5.1-8.+. Attempting to register a local signal number, this is the response :

Request verify error: javax.net.ssl.SSLPeerUnverifiedException: Hostname textsecure-service.whispersystems.org not verified:
        certificate: sha256/HM+(removed for privacy) 
 DN: CN=textsecure-service.whispersystems.org,OU=Open Whisper Systems,O=Open Whisper Systems,ST=California,C=US
        subjectAltNames: []

I haven't gone through each dependency, so any help to reproduce this is appreciated.

Thanks all, Luke

n8fr8 commented 6 years ago

It may be that we need to update the code for signal-cli-android https://github.com/guardianproject/signal-cli-android to keep up with the base project signal-cli: https://github.com/AsamK/signal-cli/commits/master

lukeswitz commented 6 years ago

Your branch is fine, it's the same idea as getting an insecure warning with a self-signed cert on a browser; appending an argument to the address works fine as does the Signal API.

The Facebook & Picasso updates are not needed, requires a higher min SDK and causes the above issue. Things start to get weird but don't break using 1.8.0 & 2.5.2:

org.havenapp.main V/StudioProfiler: Transformed class: okhttp3/OkHttpClient
org.havenapp.main W/org.havenapp.main: Current dex file has more than one class in it. 
Calling RetransformClasses on this class might fail if no transformations are applied to it!
org.havenapp.main W/System.err: Request verify error: Bad response: 400 Bad Request

Proposing PR to fix this issue.

lukeswitz commented 6 years ago

Reopened for review of PR