search

guardianproject / haven

Haven is for people who need a way to protect their personal spaces and possessions without compromising their own privacy, through an Android app and on-device sensors
https://guardianproject.github.io/haven/
GNU General Public License v3.0
6.61k stars 726 forks source link

Convert two linear layout into one constraint #287

Closed AndrewR8 closed 6 years ago

AndrewR8 commented 6 years ago

new project templates in Android Studio now use ConstraintLayout as default

the string name and the string itself are the same, and this is at least not beautiful, and it is not convenient for reading

lukeswitz commented 6 years ago

What bugs are you addressing here? The formatting of your code isn’t ready for a PR and the string change actually makes less sense.

Please explain the purpose of these proposed changes.

lukeswitz commented 6 years ago

You updated the description, thank you. The string needs to be reworded nonetheless, I believe some of this is being lost in translation.

There are other standards that need to be addressed before this, but this is good for the proposed UI overhaul and following proper design standards. (Your link is to a private page of a paid course site, please reference those directly using Google developer resources:

https://developer.android.com/guide/practices/ui_guidelines/index.html

Thanks for your help.

lukeswitz commented 6 years ago

The string is unused, changing it has nil imapact. UI feedback is adequate so far in users onboarding the decibel levels: “Make some noise” is an engaging phrase to let the user know it’s time to interact. Feedback latency is negligible compared to the motion preview and the dB levels are well explained.

A full on UI overhaul is proposed in the issues, have a look at the clean work done in #218.

You could help out #275 where the values are much more ambiguous than the audio sensor you’re working on here. Keep after it 👍

AndrewR8 commented 6 years ago

is everything okey with my commits? or i need to change something else?

n8fr8 commented 6 years ago

Sorry for the delay on reviewing this... taking a look now!

n8fr8 commented 6 years ago

Regarding the string name, the naming was done through automated externalization using Android Studio. I agree it shouldn't be the key for the strong shouldn't be the english sentence with an underscore.

That said, at this point changing keys for strings causes more problems than it solves, since we need to change them for all translations, etc, and push the updates strings and translations to Transifex.