search

guardianproject / haven

Haven is for people who need a way to protect their personal spaces and possessions without compromising their own privacy, through an Android app and on-device sensors
https://guardianproject.github.io/haven/
GNU General Public License v3.0
6.62k stars 728 forks source link

very minor tweak: /phoneypot sub-folders currently includ colon in folder names. this can be a problem. #348

Closed deviantollam closed 6 years ago

deviantollam commented 6 years ago

i see that starting in 0.2.0-beta4 the entries in /phoneypot (or whatever folder the user has configured) get their own sub-folders for individual detection events.

the sub-folders are named YYYY-MM-DD_HH:MM:SS which is a nice touch... however, the use of colons means that it's problematic for users to, say, copy these folders over to a laptop since colons are sometimes disallowed by various operating systems. using hyphens instead of colons would prevent this issue.

ideal scenario: the sub-folders in /phoneypot would be syntax'd as YYYY-MM-DD_HH-MM-SS

archie94 commented 6 years ago

True! OS like Windows will prevent any folder name with colon. Will send a patch for this!

fat-tire commented 6 years ago

See if this got fixed by #351