search

guardianproject / haven

Haven is for people who need a way to protect their personal spaces and possessions without compromising their own privacy, through an Android app and on-device sensors
https://guardianproject.github.io/haven/
GNU General Public License v3.0
6.62k stars 728 forks source link

Version 118 not compatible AOS < 6 camera #355

Closed lukeswitz closed 5 years ago

lukeswitz commented 5 years ago

Will not show the camera config/monitor views. The migration to androidx libs have issues for devices on lower APIs.

n8fr8 commented 5 years ago

Thanks for the legacy device testing. Ideally we can balance moving forward to modern, easier to manage code and modules while ensuring we support the "cheap old second device" still. I had hoped to push out 118 more widely, but alas, seems like we need to fix this pronto.

lukeswitz commented 5 years ago

It was my assumption this app was to be used on “burners” or a “cheap old second device”. I have a legacy branch that works aside from video, which never worked and broke RC 1. All in all I’m at a loss as to what this project needs or wants. Simple security was almost there.

Adding a bunch of code libraries that are most definitely not meant for burner devices has halted development. CameraPlus library worked until updated, why it was added instead of writing a little code to support both CameraAPIs?

I’d like to help protect people, yet this app is only providing a false sense of security. It was terrible reading last year the comment from somebody who needed this to work and it didn’t capture any images of the people robbing him.

The camera is almost all you need working in a “security camera” app. The smart move would be removing all unnecessary libs (dozens working against one another is doing no good)

As it’s past the three month mark without any update from Freedom of the Press, Nate F or otherwise- I have to ask: has the funding for this project ($33k last I looked) been reallocated? Is Haven on the shelf?

Appreciate your response & efforts,

n8fr8 commented 5 years ago

Hey, luke, and thanks for the continued support and interest. I've been occupied with some other major, but related projects (infrastructure work for Tor, Onion Services, secure messaging, etc), for the last few months. I and other Guardian Project team members have also been doing a lot of work with activists in need of physical protection out in the field. We've been gathering feedback, usability input and more, as part of our broad work, but also on Haven. So, while I haven't been active here on the code, I have been actively observing and reflecting on use of Haven, and the way forward.

Regardless, that isn't an excuse for not ensuring the current app is stable and available for all the platforms we claim to support. I have been working with some new CameraView projects with other apps, and think what we need here is an overall of this particular piece of code. If there is a short term fix for the AOS < 6 issue, I'll get that done first, but in the long run, in order to support video well, and support a broad range of OSes, we need some more robust code in the Camera department.

lukeswitz commented 5 years ago

Thanks for the kind and thorough response, and mostly thanks for all you do out in the field. Exciting to see the repo active again!

n8fr8 commented 5 years ago

Found and fixed an issue in #361 related to RenderScript through AndroidX being broken on devices below Android SDK 23. It turns out that using RenderScript doesn't buy us much performance improvement, so removing the dependency for now!