search

guardianproject / haven

Haven is for people who need a way to protect their personal spaces and possessions without compromising their own privacy, through an Android app and on-device sensors
https://guardianproject.github.io/haven/
GNU General Public License v3.0
6.63k stars 728 forks source link

for #365 reduce camera resolution and remove one unneeded bitmap #366

Closed n8fr8 closed 5 years ago

archie94 commented 5 years ago

With the default motion detection sensitivity threshold performance is better on this branch. However reducing the threshold to something around 948 I am still running into ANRs. :/

n8fr8 commented 5 years ago

... but no OOMs?

On Thu, Feb 7, 2019, at 3:57 PM, Arka Prava Basu wrote:

With the default motion detection sensitivity threshold performance is better on this branch. However reducing the threshold to something around 948 I am still running into ANRs. :/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/guardianproject/haven/pull/366#issuecomment-461583798, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB4gwv7TwdXrZK3q9qnIWW9MFzjzlWcks5vLIx8gaJpZM4apJ2B.

archie94 commented 5 years ago

Faced OOMs too! Will provide the crashlog in some time.

n8fr8 commented 5 years ago

This latest commit should vastly simplify the processing going on during motion detection. The problem was really in the whole overlay bitmap UI generation. That UI is fun, but not that usable. I am now just displaying a simple string "motion detection" to indicate a match.

This is part of new work on showing more of an interactive display for all sensor matches, like "Sound Detected" or "Device Moved" etc, so that you can see in one view all of the various sensor states.

archie94 commented 5 years ago

Can confirm! No more ANRs or OOM errors 👍 !

However the number of Triggers of type Motion(Camera) is significantly reduced. Is this intended?

archie94 commented 5 years ago 
However the number of Triggers of type Motion(Camera) is significantly reduced. Is this intended?

Preliminary testing. Would be great if someone can cross-verify.

lukeswitz commented 5 years ago

Notes: Getting a crash using camera on nexus 4 & 5 (AOS 5&6), with the monitor continuing in the background. Less frames could benefit the load on notifications. Without the overlay it's very hard to use sensitivity config.

Edit: after latest commit, feedback for when sound and motion is detected works well and is intuitive. Makes much more sense moving forward. Thank you both. 


  --------- beginning of crash
02-08 17:46:10.367 26412-26412/org.havenapp.main E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.havenapp.main, PID: 26412
    java.lang.IllegalStateException: Fragment CameraFragment{258a9de5} not attached to a context.
        at androidx.fragment.app.Fragment.requireContext(Fragment.java:696)
        at androidx.fragment.app.Fragment.getResources(Fragment.java:760)
        at androidx.fragment.app.Fragment.getString(Fragment.java:782)
        at org.havenapp.main.ui.CameraFragment$1.handleMessage(CameraFragment.java:56)
n8fr8 commented 5 years ago

@lukeswitz I found and fixed that crash.

Otherwise, going to finish this up, and then work on improving tuning and feedback UI in another PR.