Make Signal on-boarding user-friendly

guardianproject / haven

Haven is for people who need a way to protect their personal spaces and possessions without compromising their own privacy, through an Android app and on-device sensors

https://guardianproject.github.io/haven/

GNU General Public License v3.0

6.62k stars 728 forks source link

Make Signal on-boarding user-friendly #387

Closed archie94 closed 5 years ago

archie94 commented 5 years ago

have a callback mechanism for every signal operations

Signed-off-by: Arka Prava Basu arkaprava94@gmail.com

archie94 commented 5 years ago

Registration and Verification will now show a toast denoting success or failure (Better UI required to denote the procedure(s) are running in background)
For all other Signal communications request and result are logged.

n8fr8 commented 5 years ago

looking good...

archie94 commented 5 years ago

Have introduced a new flag to track Signal number verification. This is hopefully provide better clarity to users on the state of their Signal on-boarding.

Have added an option to wipe out Signal setup. This will help users to restart their on-boarding process without having to do a clear app data / re-install.

The downside is on an app upgrade we have no way of identifying whether Signal is setup successfully (registered and verified). We may need to ask the ones updating their app to Reset Signal configuration and on-board again. :/

archie94 commented 5 years ago

Further scopes of improvement:

show better failure msg when Signal registration or verification fails.

This is require changes in signal-cli lib. Will pick this up in a separate PR!

n8fr8 commented 5 years ago

@archie94 thanks for all the excellent work on this!