LeakCanary investigation to find memory leaks

guardianproject / haven

Haven is for people who need a way to protect their personal spaces and possessions without compromising their own privacy, through an Android app and on-device sensors

https://guardianproject.github.io/haven/

GNU General Public License v3.0

6.58k stars 728 forks source link

LeakCanary investigation to find memory leaks #395

Open archie94 opened 5 years ago

archie94 commented 5 years ago

~~Call cameraview destroy() instead of close() on Fragment onDestroy()~~ Do the same with LifecycleOwner -> #393

destroy() releases the camera resource unlike close() which just stops the preview (Seems to fix #393 #394 #392 #391 )

archie94 commented 5 years ago

Some major leaks around Camera, Settings, Signal and MaterialDateTime Picker fixed. Please test once and consider merging.

n8fr8 commented 5 years ago

Merged fine, and is not crashing, but seem to not be capturing all the camera positive detect events. Will dig and test some more.

n8fr8 commented 5 years ago

Definitely something different happening with logging events. Master works fine, but this PR seems to not be persisting matched events.

archie94 commented 5 years ago

:/ Will check it out! Meanwhile if you feel it is happening for any specific scenario or find any steps to reproduce do leave them here.

I hope these event / event triggers are solely around the camera?

Thanks for the testing!