search

guardianproject / haven

Haven is for people who need a way to protect their personal spaces and possessions without compromising their own privacy, through an Android app and on-device sensors
https://guardianproject.github.io/haven/
GNU General Public License v3.0
6.58k stars 728 forks source link

Update to latest AS and hopefully fix video crash (#410) #411

Closed fat-tire closed 4 years ago

fat-tire commented 4 years ago

I think these changes should speak for themselves, but the important ones are the AndroidManifest change to support access to external storage in Android 10 and the video player (fixes to ConstraintLayout and CoordinatorLayout).

In my emulator build the video doesn't encode fast enough, so the videos are black, but I dont' know if this is an issue beyond my system. Didn't test on an actual device-- maybe someone else can.

Build requires recent Android Studio 4 Canary (I'm using 8)

Cheers! ft

lukeswitz commented 4 years ago

Going to test this today, but I believe this nails the root cause of most media issues. Thanks for grinding and pushing this through!

fat-tire commented 4 years ago

My pleasure... As I said, the emulator was a bit slow in writing the mp4 files so I can't vouch for that but it looked at least like it was trying to play them :)

lukeswitz commented 4 years ago

Thank you, and great work. Aside from an audio encoding issue and image rotation, this is running smooth on 5.1. Looks great aside from a couple header titles. What was a blank frame w/video recording enabled in previous builds now shows a clear image in logs 👍🤯

Notes:

(1) No crash on motion event (Tested: Device AOS 5 - Nexus4 / Emulator 5.1 x86 w/o GoogleAPIs) (2) Video did not play using current encoding when selected, although preview frame exists

n8fr8 commented 4 years ago

Testing and merging ASAP, thanks as always.