guardianproject / haven

Haven is for people who need a way to protect their personal spaces and possessions without compromising their own privacy, through an Android app and on-device sensors
https://guardianproject.github.io/haven/
GNU General Public License v3.0
6.63k stars 728 forks source link

Signal notifications are broken #445

Open n8fr8 opened 3 years ago

n8fr8 commented 3 years ago

Moving to WhisperSystem's lisignal library directly here:

https://github.com/guardianproject/haven/tree/libsignal-update

n8fr8 commented 3 years ago

@lukeswitz @archie94 if you have any interest here to pitch on this, happy to have some help!

Once we get this working, going to push out an official 0.3 beta/release.

archie94 commented 3 years ago

Kindly allow me some time. Will get back on this.

n8fr8 commented 3 years ago

I've gotten pieces of it done, but need to figure out how to implement the Signal protocol store.

https://github.com/guardianproject/haven/tree/libsignal-update/src/main/java/org/havenapp/main/service/signal

exaveal commented 3 years ago

Lot of people waiting for having the app back online. Thx so much! Looking forward to be able to use it again!

archie94 commented 3 years ago

So the library in itself seems deprecated and out of date. https://github.com/signalapp/libsignal-service-java/issues/83

And its replacement seems to be embedded inside the main android app repository. One idea comes to my mind, lets see if that works for us.

lukeswitz commented 3 years ago

One idea comes to my mind, lets see if that works for us.

Thanks, I was also stuck on the legacy implementation, both ideological and technical, so I appreciate your help @archie94 🤝

n8fr8 commented 3 years ago

There is also the signald.org project, though that may be building on the out of data libsignal-service-java.

Maybe we should extract libsignal from the Signal Android repo?

n8fr8 commented 3 years ago

Actually we should use this: https://github.com/signalapp/libsignal-client

archie94 commented 3 years ago

There is also the signald.org project, though that may be building on the out of data libsignal-service-java.

Maybe we should extract libsignal from the Signal Android repo?

Yeah i was thinking along similar lines ...

Actually we should use this: https://github.com/signalapp/libsignal-client

But this looks better. :+1:

closingin commented 2 years ago

Hello there !

I was looking forward to use Signal notifications, has there been any progress on this issue ?

archie94 commented 2 years ago

Hello,

Exploring https://github.com/signalapp/libsignal-client but documentation is not very clear and it seems we need to implement security layers on top of the basic messaging functionality to get it working. This is significant task at the moment which will take time from my end. Will update from my side as I have anything significant.

Gottale commented 1 year ago

I came across this project and was reminded of the issues with haven/signal. https://github.com/AsamK/signal-cli Appears to be using a forked version of libsignal-service-java thats updated quite regularly.

Is this of any help?

joeyboon commented 1 year ago

Hi, I would just like to state that this issue still persists. Hopefully you will be able to fix this.

lukeswitz commented 1 year ago

I found a few ways to make it work. Problem is, rest of the app is in need of serious love. In communication with Google now should we want SMS as a fallback.