guardianproject / orbot-apple

Orbot VPN app for iOS
MIT License
186 stars 34 forks source link

Delete Blackberry STUN Server #52

Closed bitmold closed 1 year ago

bitmold commented 1 year ago

This one: stun:stun.voip.blackberry.com:3478

Tor Browser hasn't used it in some time: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/fc89e8b10c3ff30db2079b2fb327d05b2b5f3c80

https://github.com/guardianproject/orbot/pull/805

bitmold commented 1 year ago

How would you feel about keeping a default list of STUN Servers in IPtProxy. On the one hand it's kind of annoying to build that big binary whenever the legit servers go up/down, but on the other hand these STUN servers haven't ever changed that much over time, and there's definitely something appealing to me about making the change in one place and having it propagate across Orbot Android, Orbot Apple, whatever other software...

tladesignz commented 1 year ago

IDK. This is very Tor-specific, whereas IPtProxy is very non-Tor specific.

For my iOS apps, I keep this in another lib:

https://github.com/tladesignz/IPtProxyUI-ios/blob/main/IPtProxyUI/Classes/Shared/Transport.swift#L26

(I know, the name is not great, since that lib is very Tor specific.)

How about you doing a similar library for Android?

tladesignz commented 1 year ago

Almost overlooked the broken Blackberry STUN. Thank you!

bitmold commented 1 year ago

IDK. This is very Tor-specific, whereas IPtProxy is very non-Tor specific

That makes s lot of sense, thanks

tladesignz commented 1 year ago

Fixed for iOS: https://github.com/tladesignz/IPtProxyUI-ios/commit/08f2bcedec491afc7442d06642e7244ec8322cd3