search

guardianproject / orbot

The Github home of Orbot: Tor on Android (Also available on gitlab!)
https://gitlab.com/guardianproject/orbot
Other
1.98k stars 325 forks source link

Align and format cancel/connect buttons #1076

Closed syphyr closed 3 months ago

syphyr commented 3 months ago

This PR is built off of @meenbeese's work to align the cancel/connect buttons for tablets. It also changes the shape of the buttons to match the rest of the UI.

bitmold commented 3 months ago

Wow great, could you throw up some screenshots here please though

syphyr commented 3 months ago

Screenshots:

Screenshot_20240128-224605

Screenshot_20240128-224620

Screenshot_20240128-224634

meenbeese commented 3 months ago

The screenshots look good, but there is clearly too much bottom margin on the second and third one. Can you bring the buttons down like in the first screenshot?

bitmold commented 3 months ago

I can do that, since there's a few other UI things like the title being indented that I want to fix...