guardianproject / orbot

The Github home of Orbot: Tor on Android (Also available on gitlab!)
https://gitlab.com/guardianproject/orbot
Other
2.27k stars 338 forks source link

Remove obsolete LibEvent URL in about #1103

Closed meenbeese closed 8 months ago

meenbeese commented 8 months ago

The old URL now redirects to the new one: https://www.libevent.org

Edit: Orbot does not directly rely on LibEvent, thus all links have been removed.

syphyr commented 8 months ago

libevent (2.1.12) has moved into the tor-android project and is indirectly linked into Orbot from libtor.so. This must have been left over from a very old version of orbot. Descriptions of libevent in orbot should be removed, not updated.

meenbeese commented 8 months ago

libevent (2.1.12) has moved into the tor-android project and is indirectly linked into Orbot from libtor.so. This must have been left over from a very old version of orbot. Descriptions of libevent in orbot should be removed, not updated.

Done! Thanks for the valuable insight.

bitmold commented 6 months ago

I disagree, we still compile libevent and that's a functional aspect of Orbot's tor binary, I think it's worth updating and not removing.

I think it's actually bworthwhile to include this kind of info for not just libevent, but zlib, zstd and any other dependencies that shows what the little t tor within Orbot is running with.

It'd actually be nice to include these in TorService so not just Orbot but any tor-android app can access this info. Adds transparency and shows users whether or not we are on top of things.

bitmold commented 6 months ago

In the future for strings like this we can set traslateable=false on these kinds of string resources, wastes space and is confusing/noise for translators