guardianproject / orbot

The Github home of Orbot: Tor on Android (Also available on gitlab!)
https://gitlab.com/guardianproject/orbot
Other
2.27k stars 338 forks source link

Simplify version name fetch in about #1116

Closed meenbeese closed 7 months ago

meenbeese commented 7 months ago

The previous approach was more error-prone (required a try-catch block) because it fetched the app version name at runtime. The new approach instead uses Gradle's buildConfig feature to fetch it safely from Gradle at compile time. This helps simplify the code and aligns with the approach that OrbotService already uses to obtain the Tor version.