search

guardianproject / orbot

The Github home of Orbot: Tor on Android (Also available on gitlab!)
https://gitlab.com/guardianproject/orbot
Other
1.98k stars 325 forks source link

Rewrite OnionServiceDeleteDialogFragment in Kotlin #1123

Closed meenbeese closed 1 week ago

meenbeese commented 3 weeks ago

Continues the Kotlin rewrite with the Onion Service.

Tested on Pixel 8 API 34.

bitmold commented 1 week ago

Looks good, but wondering if you have you used this code to delete an onion service and have seen the functionality to be the same?

meenbeese commented 1 week ago

Looks good, but wondering if you have you used this code to delete an onion service and have seen the functionality to be the same?

Yes, I have tested it using the emulator and it seems to work fine.

https://github.com/guardianproject/orbot/assets/114044633/3243109c-7153-4056-b64e-f51da0a2d95f

bitmold commented 1 week ago

Cool thanks! If you're up for it, it'd be cool to have this screen use an empty view for when there are no user/app services being listed..

meenbeese commented 1 week ago

Thanks for the feedback, you mean a placeholder text/image like this, right? I was already planning to improve the UI by replacing the radio buttons with segmented buttons and this can be a nice addition to that.

bitmold commented 1 week ago

Yup, that's what I meant !