search

guardianproject / orbot

The Github home of Orbot: Tor on Android (Also available on gitlab!)
https://gitlab.com/guardianproject/orbot
Other
2.27k stars 338 forks source link

Migration to the Material 3 style #984

Open meenbeese opened 1 year ago

meenbeese commented 1 year ago

Upgrading our app to Material 3 is essential for a modern aesthetic, aligning with design trends. This transition enables seamless adaptation to user wallpaper colors and introduces a much-needed light mode. Addressing issues #736 and #861 is critical, as they are key steps in the comprehensive overhaul of components and libraries. Systematically reworking these elements ensures a smooth transition, creating a visually appealing and user-friendly app in line with contemporary expectations.

RedSteel-1 commented 1 year ago

Please Do Not do this. No way. If this flat eye-bleeding ugliness that some call "a design" comes to Orbot, I will forever stick to the last pre-"redesign" version.

meenbeese commented 1 year ago

If I wasn't clear enough before, this should be implemented as an option that can be toggled, as most apps do. This way, users can choose to use the default colors of Orbot and not be bound to their wallpaper colors. I assume that's what your concern is?

RedSteel-1 commented 1 year ago

m3 is not only the colours, it is also the overall ugly flat and childish-bubble-ish look

RokeJulianLockhart commented 7 months ago

https://github.com/guardianproject/orbot/issues/984#issue-1916273743

@meenbeese, https://gitlab.com/guardianproject/torservices/-/issues/6 relates.

meenbeese commented 3 months ago

I am gearing to do the migration like this: AppCompat -> Material Components -> Material3, where we currently are at AppCompat and will use the next step as an intermediate one towards M3. I just need to get in a couple of fixes before I can share a beta here to get some feedback, if anyone is up for it :)